Hi! > > + */ > > + > > +#include <linux/kernel.h> > > +#include <linux/module.h> > > +#include <linux/spmi.h> > > +#include <linux/of_device.h> > > +#include <linux/device.h> > > +#include <linux/types.h> > > +#include <linux/string.h> > > +#include <linux/mutex.h> > > +#include <linux/sysfs.h> > > +#include <linux/led-class-flash.h> > > +#include <linux/regulator/consumer.h> > > +#include <linux/delay.h> > > +#include <linux/regmap.h> > > +#include <dt-bindings/leds/leds-qcom-spmi-flash.h> > > Please sort includes alphabetically.
No need to do that.
> > +#define FLASH_SAFETY_TIMER 0x40
>
> Namespacing prefix is needed for macros, e.g. QCOM_FLASH*.
No need for that in .c files.
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
signature.asc
Description: PGP signature
