On Thu, Feb 25, 2021 at 03:15:42PM -0800, Hugh Dickins wrote:
> All of the VM NUMA stats are event counts, incremented never decremented:
> it is not very useful for vmstat_refresh() to check them throughout their
> first aeon, then warn on them throughout their next.
> 
> Signed-off-by: Hugh Dickins <hu...@google.com>

Acked-by: Roman Gushchin <g...@fb.com>

Thanks!

> ---
> 
>  mm/vmstat.c |    9 ---------
>  1 file changed, 9 deletions(-)
> 
> --- vmstat3/mm/vmstat.c       2021-02-25 12:42:15.000000000 -0800
> +++ vmstat4/mm/vmstat.c       2021-02-25 12:44:20.000000000 -0800
> @@ -1854,15 +1854,6 @@ int vmstat_refresh(struct ctl_table *tab
>                               __func__, zone_stat_name(i), val);
>               }
>       }
> -#ifdef CONFIG_NUMA
> -     for (i = 0; i < NR_VM_NUMA_STAT_ITEMS; i++) {
> -             val = atomic_long_read(&vm_numa_stat[i]);
> -             if (val < 0) {
> -                     pr_warn("%s: %s %ld\n",
> -                             __func__, numa_stat_name(i), val);
> -             }
> -     }
> -#endif
>       for (i = 0; i < NR_VM_NODE_STAT_ITEMS; i++) {
>               /*
>                * Skip checking stats known to go negative occasionally.

Reply via email to