Hi Steven. > Index: linux-compile-i386.git/arch/x86/Kconfig > =================================================================== > --- linux-compile-i386.git.orig/arch/x86/Kconfig 2008-01-09 > 14:09:36.000000000 -0500 > +++ linux-compile-i386.git/arch/x86/Kconfig 2008-01-09 14:10:07.000000000 > -0500 > @@ -28,6 +28,10 @@ config GENERIC_CMOS_UPDATE > bool > default y > > +config ARCH_HAS_MCOUNT > + bool > + default y > +
Please use the following scheme: arch/x86/Kconfig: config X86 + select HAVE_MCOUNT lib/tracing/Kconfig + # ARCH shall select HAVE_MCOUNT if they provide this function + config HAVE_MCOUNT + bool + + config MCOUNT + bool + select FRAME_POINTER And then in your later patches: +config MCOUNT_TRACER + bool "Profiler instrumentation based tracer" + depends on DEBUG_KERNEL && HAVE_MCOUNT + select MCOUNT + help + Use profiler.... The "default n" is a noop since this is the default. And note that the depends on is removed from MCOUNT because you use it as a select target (so dependencies are not checked anyway). With this scheme implmented you: - Use new naming convention (HAVE_*) - Avoid defining one config variable per arch - Do not have dependencies on selected symbols - More compact representation in arch Kconfig files Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/