When mutex_lock_interruptible() fails, the error return code of tomoyo_update_domain() is not properly assigned. To fix this bug, error is assigned with the return value of mutex_lock_interruptible(), and then error is checked.
Reported-by: TOTE Robot <[email protected]> Signed-off-by: Jia-Ju Bai <[email protected]> --- security/tomoyo/domain.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/security/tomoyo/domain.c b/security/tomoyo/domain.c index 98d985895ec8..7b9f9664dbe3 100644 --- a/security/tomoyo/domain.c +++ b/security/tomoyo/domain.c @@ -118,7 +118,8 @@ int tomoyo_update_domain(struct tomoyo_acl_info *new_entry, const int size, ->perm == 1 << TOMOYO_TYPE_EXECUTE)) goto out; } - if (mutex_lock_interruptible(&tomoyo_policy_lock)) + error = mutex_lock_interruptible(&tomoyo_policy_lock); + if (error) goto out; list_for_each_entry_rcu(entry, list, list, srcu_read_lock_held(&tomoyo_ss)) { -- 2.17.1
