On Tue, Mar 09, 2021 at 12:02:47PM +0000, Caleb Connolly wrote:
> +static inline u32 ufshci_version(u32 major, u32 minor) {
> + return (((major) << 8) + ((minor) << 4));
> +}Kernel style puts the opening curly brace on a separate line. Also for an inline function adding parentheses is not required (unlike for macros). Otherwise this looks good: Reviewed-by: Christoph Hellwig <[email protected]>
