Hi Rob,
Thanks for providing the review comments.
Please find my response inline.
> -----Original Message-----
> From: Rob Herring <[email protected]>
> Sent: Tuesday, March 9, 2021 1:50 AM
> To: Nava kishore Manne <[email protected]>
> Cc: [email protected]; [email protected]; Michal Simek <[email protected]>;
> [email protected]; Jolly Shah <[email protected]>; Rajan Vaja
> <[email protected]>; [email protected]; Manish Narani
> <[email protected]>; Amit Sunil Dhamne <[email protected]>; Tejas
> Patel <[email protected]>; [email protected];
> [email protected]; [email protected]; linux-arm-
> [email protected]; [email protected]; Appana Durga
> Kedareswara Rao <[email protected]>
> Subject: Re: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga
> manager
>
> On Thu, Mar 04, 2021 at 12:32:23PM +0530, Nava kishore Manne wrote:
> > From: Appana Durga Kedareswara rao <[email protected]>
> >
> > This patch adds binding doc for versal fpga manager driver.
>
> Why do you need a DT entry for this? Can't the Versal firmware driver
> instantiate the fpga-mgr device?
>
This dt entry is need to handle the fpga regions properly for both full and
Partial bitstream loading use cases and it cannot be done by Versal firmware
driver instantiate.
Complete firmware DT node example is shown below for your reference.
Example for full FPGA configuration:
fpga-region0 {
compatible = "fpga-region";
fpga-mgr = <&versal_fpga>;
#address-cells = <0x1>;
#size-cells = <0x1>;
};
firmware {
zynqmp_firmware: zynqmp-firmware {
compatible = "xlnx,zynqmp-firmware";
method = "smc";
versal_fpga: fpga {
compatible = "xlnx,versal-fpga";
};
};
};
Please correct me if my understanding is wrong...
Regards,
Navakishore.
