On Sat, Mar 13, 2021 at 04:38:14AM +0900, Masahiro Yamada wrote: > ld-version.sh checks the output from $(LD) --version, but it has a > problem on some locales. > > For example, in Italian: > > $ LC_MESSAGES=it_IT.UTF-8 ld --version | head -n 1 > ld di GNU (GNU Binutils for Debian) 2.35.2 > > This makes ld-version.sh fail because it expects "GNU ld" for the > BFD linker case. > > Add LC_ALL=C to override the user's locale. > > BTW, setting LC_MESSAGES=C (or LANG=C) is not enough because it is > ineffective if LC_ALL is set on the user's environment. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=212105 > Reported-by: Marco Scardovi > Signed-off-by: Masahiro Yamada <masahi...@kernel.org>
LGTM, this is Debian's recommendation as well: https://wiki.debian.org/Locale Reviewed-by: Nathan Chancellor <nat...@kernel.org> > --- > > scripts/ld-version.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/ld-version.sh b/scripts/ld-version.sh > index 30debf78aa09..1bf3aadde9de 100755 > --- a/scripts/ld-version.sh > +++ b/scripts/ld-version.sh > @@ -29,7 +29,7 @@ orig_args="$@" > # Get the first line of the --version output. > IFS=' > ' > -set -- $("$@" --version) > +set -- $(LC_ALL=C "$@" --version) > > # Split the line on spaces. > IFS=' ' > -- > 2.27.0 >
