On Thu, Mar 11, 2021 at 11:17:27AM +0000, Colin King wrote: > From: Colin Ian King <[email protected]> > > The variables state and ee are being initialized with values that > are never read and are being updated later with a new values. The > initializations are redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <[email protected]>
Reviewed-by: Manivannan Sadhasivam <[email protected]> Thanks, Mani > --- > drivers/bus/mhi/core/main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c > index 2c61dfd01353..3faf8bade520 100644 > --- a/drivers/bus/mhi/core/main.c > +++ b/drivers/bus/mhi/core/main.c > @@ -428,9 +428,9 @@ irqreturn_t mhi_intvec_threaded_handler(int irq_number, > void *priv) > { > struct mhi_controller *mhi_cntrl = priv; > struct device *dev = &mhi_cntrl->mhi_dev->dev; > - enum mhi_state state = MHI_STATE_MAX; > + enum mhi_state state; > enum mhi_pm_state pm_state = 0; > - enum mhi_ee_type ee = MHI_EE_MAX; > + enum mhi_ee_type ee; > > write_lock_irq(&mhi_cntrl->pm_lock); > if (!MHI_REG_ACCESS_VALID(mhi_cntrl->pm_state)) { > -- > 2.30.2 >
