2008/1/15, Miklos Szeredi <[EMAIL PROTECTED]>: > > Thanks for your review, Peter and Miklos! > > > > I overlooked this case when AS_MCTIME flag has been turned off and the > > page is still dirty. > > > > On the other hand, the words "shall be marked for update" may be > > considered as just setting the AS_MCTIME flag, not updating the time > > stamps. > > > > What do you think about calling mapping_update_time() inside of "if > > (MS_SYNC & flags)"? I suggest such change because the code for > > analysis of the case you've mentioned above seems impossible to me. > > I think that's a good idea. As a first iteration, just updating the > mtime/ctime in msync(MS_SYNC) and remove_vma() (called at munmap time) > would be a big improvement over what we currently have. > > I would also recommend, that you drop mapping_update_time() and the > related functions from the patch, and just use file_update_time() > instead.
Thank you for your recommendations. I will submit my new solution shortly. By the way, I've already changed the unlink_file_vma() function. > > Miklos > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
