Fixed coding style issues.

Signed-off-by: Luiz Sampaio <sampaio....@gmail.com>
---
 drivers/w1/slaves/w1_ds2438.c | 26 ++++++++++++--------------
 1 file changed, 12 insertions(+), 14 deletions(-)

diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c
index 5cfb0ae23e91..a9884fc8c726 100644
--- a/drivers/w1/slaves/w1_ds2438.c
+++ b/drivers/w1/slaves/w1_ds2438.c
@@ -154,11 +154,9 @@ static int w1_ds2438_change_config_bit(struct w1_slave 
*sl, u8 mask, u8 value)
 
                if ((status & mask) == value)
                        return 0;       /* already set as requested */
-               else {
-                       /* changing bit */
-                       status ^= mask;
-                       perform_write = 1;
-               }
+               /* changing bit */
+               status ^= mask;
+               perform_write = 1;
                break;
        }
 
@@ -287,9 +285,9 @@ static ssize_t iad_read(struct file *filp, struct kobject 
*kobj,
        if (!buf)
                return -EINVAL;
 
-       if (w1_ds2438_get_current(sl, &voltage) == 0) {
+       if (w1_ds2438_get_current(sl, &voltage) == 0)
                ret = snprintf(buf, count, "%i\n", voltage);
-       } else
+       else
                ret = -EIO;
 
        return ret;
@@ -338,9 +336,9 @@ static ssize_t temperature_read(struct file *filp, struct 
kobject *kobj,
        if (!buf)
                return -EINVAL;
 
-       if (w1_ds2438_get_temperature(sl, &temp) == 0) {
+       if (w1_ds2438_get_temperature(sl, &temp) == 0)
                ret = snprintf(buf, count, "%i\n", temp);
-       } else
+       else
                ret = -EIO;
 
        return ret;
@@ -359,9 +357,9 @@ static ssize_t vad_read(struct file *filp, struct kobject 
*kobj,
        if (!buf)
                return -EINVAL;
 
-       if (w1_ds2438_get_voltage(sl, DS2438_ADC_INPUT_VAD, &voltage) == 0) {
+       if (w1_ds2438_get_voltage(sl, DS2438_ADC_INPUT_VAD, &voltage) == 0)
                ret = snprintf(buf, count, "%u\n", voltage);
-       } else
+       else
                ret = -EIO;
 
        return ret;
@@ -380,15 +378,15 @@ static ssize_t vdd_read(struct file *filp, struct kobject 
*kobj,
        if (!buf)
                return -EINVAL;
 
-       if (w1_ds2438_get_voltage(sl, DS2438_ADC_INPUT_VDD, &voltage) == 0) {
+       if (w1_ds2438_get_voltage(sl, DS2438_ADC_INPUT_VDD, &voltage) == 0)
                ret = snprintf(buf, count, "%u\n", voltage);
-       } else
+       else
                ret = -EIO;
 
        return ret;
 }
 
-static BIN_ATTR(iad, S_IRUGO | S_IWUSR | S_IWGRP, iad_read, iad_write, 0);
+static BIN_ATTR(iad, 0664, iad_read, iad_write, 0);
 static BIN_ATTR_RO(page0, DS2438_PAGE_SIZE);
 static BIN_ATTR_RO(temperature, 0/* real length varies */);
 static BIN_ATTR_RO(vad, 0/* real length varies */);
-- 
2.30.1

Reply via email to