Quoting Douglas Anderson (2021-03-15 10:38:54) > As per Dmitry Baryshkov [1]: > a) The 2nd "reg" should be 0x3c because "Offset 0x38 is > USB3_DP_COM_REVISION_ID3 (not used by the current driver though)."
I see 0x34 for the offset here instead of 0x38 but I don't think it really matters either way. > b) The 3rd "reg" "is a serdes region and qmp_v3_dp_serdes_tbl contains > registers 0x148 and 0x154." > > I think because the 3rd "reg" is a serdes region we should just use > the same size as the 1st "reg"? > > [1] https://lore.kernel.org/r/[email protected] > > Cc: Stephen Boyd <[email protected]> > Cc: Jeykumar Sankaran <[email protected]> > Cc: Chandan Uddaraju <[email protected]> > Cc: Vara Reddy <[email protected]> > Cc: Tanmay Shah <[email protected]> > Cc: Rob Clark <[email protected]> > Fixes: 58fd7ae621e7 ("arm64: dts: qcom: sc7180: Update dts for DP phy inside > QMP phy") > Reported-by: Dmitry Baryshkov <[email protected]> > Signed-off-by: Douglas Anderson <[email protected]> > --- Reviewed-by: Stephen Boyd <[email protected]>
