On Fri, Mar 12, 2021 at 09:57:56PM +0800, Ray Chi wrote: > Hi Sebastian, > > Sorry for the late reply. > > On Wed, Mar 10, 2021 at 2:58 AM Sebastian Reichel <[email protected]> wrote: > > > > Hi, > > > > On Mon, Mar 08, 2021 at 09:31:46PM +0800, Ray Chi wrote: > > > Fix build error when CONFIG_POWER_SUPPLY is not enabled. > > > > > > The build error occurs in mips (cavium_octeon_defconfig). > > > > > > mips-linux-gnu-ld: drivers/usb/dwc3/core.o: in function `dwc3_remove': > > > drivers/usb/dwc3/core.c:1657: undefined reference to `power_supply_put' > > > mips-linux-gnu-ld: drivers/usb/dwc3/core.o: in function > > > `dwc3_get_properties': > > > drivers/usb/dwc3/core.c:1270: undefined reference to > > > `power_supply_get_by_name' > > > mips-linux-gnu-ld: drivers/usb/dwc3/core.o: in function `dwc3_probe': > > > drivers/usb/dwc3/core.c:1632: undefined reference to `power_supply_put' > > > > > > Fixes: 59fa3def35de ("usb: dwc3: add a power supply for current control") > > > Reported-by: Naresh Kamboju <[email protected]> > > > Signed-off-by: Ray Chi <[email protected]> > > > --- > > > > While I'm fine with merging this after fixing up the subject, the > > original patch for dwc3 [0] looks completly incorrect to me. > > > > First of all it uses wrong scale (power-supply uses uA, not mA), > > so you are charging 1000x slower than expected. Then the patchset > > introduces a new DT property to get the power-supply device, but > > does not update the DT binding documentation and does not Cc the > > DT binding maintainer. > > Yes, it should use uA and send this information, and I will update a > patch to fix it and add the DT binding documentation.
So should I revert what we currently have in my usb-next tree, or do you have a fix for this? thanks, greg k-h
