On Thu, 1 Apr 2021 19:09:43 +0800 Wan Jiabing <[email protected]> wrote:
> checkdeclares: find struct declared more than once. > Inspired by checkincludes.pl. > This script checks for duplicate struct declares. > Note that this will not take into consideration macros, so > you should run this only if you know you do have real dups > and do not have them under #ifdef's. > You could also just review the results. include/linux/bpf-cgroup.h: struct bpf_prog is declared more than once. include/linux/bpf.h: struct xdp_buff is declared more than once. include/linux/bpf.h: struct sk_buff is declared more than once. include/linux/bpf.h: struct btf_type is declared more than once. include/linux/debug_locks.h: struct task_struct is declared more than once. include/linux/fs.h: struct iov_iter is declared more than once. include/linux/fs.h: struct files_struct is declared more than once. include/linux/gpio.h: struct device is declared more than once. include/linux/host1x.h: struct host1x is declared more than once. include/linux/intel_rapl.h: struct rapl_package is declared more than once. include/linux/libnvdimm.h: struct device is declared more than once. include/linux/lightnvm.h: struct nvm_rq is declared more than once. include/linux/memcontrol.h: struct mem_cgroup is declared more than once. include/linux/mount.h: struct path is declared more than once. include/linux/mutex.h: struct ww_acquire_ctx is declared more than once. include/linux/netfilter.h: struct flowi is declared more than once. include/linux/netfilter.h: struct nf_conntrack_tuple is declared more than once. include/linux/netfilter.h: struct nlattr is declared more than once. include/linux/netfilter.h: struct nf_conn is declared more than once. include/linux/profile.h: struct pt_regs is declared more than once. include/linux/trace_events.h: struct trace_array is declared more than once. Sigh. I keep telling them - "put the forward declaration at top-of-file so it doesn't get duplicated later on". Nobody listens to Andrew. > --- /dev/null > +++ b/scripts/checkdeclares.pl > @@ -0,0 +1,53 @@ > +#!/usr/bin/env perl > +# SPDX-License-Identifier: GPL-2.0 > +# > +# checkdeclares: find struct declared more than once > +# > +# Copyright 2021 Wan Jiabing<[email protected]> > +# Inspired by checkincludes.pl > +# > +# This script checks for duplicate struct declares. > +# Note that this will not take into consideration macros so > +# you should run this only if you know you do have real dups > +# and do not have them under #ifdef's. > +# You could also just review the results. > + > +use strict; > + > +sub usage { > + print "Usage: checkdeclares.pl \n"; > + print "We just warn of struct declaration duplicates\n"; Not quite accurate. I added this fixup: --- a/scripts/checkdeclares.pl~scripts-a-new-script-for-checking-duplicate-struct-declaration-fix +++ a/scripts/checkdeclares.pl @@ -15,8 +15,8 @@ use strict; sub usage { - print "Usage: checkdeclares.pl \n"; - print "We just warn of struct declaration duplicates\n"; + print "Usage: checkdeclares.pl file1.h ...\n"; + print "Warns of struct declaration duplicates\n"; exit 1; }
