Hi, On Fri, Apr 02, 2021 at 01:50:18PM +0300, Claudiu Beznea wrote: > Use devm_of_iomap() to map resources. This will avoid the necessity to > track the mapped resources and free them on failure path or on remove. > > Reported-by: kernel test robot <l...@intel.com> > Reported-by: Dan Carpenter <dan.carpen...@oracle.com> > Suggested-by: Nicolas Ferre <nicolas.fe...@microchip.com> > Signed-off-by: Claudiu Beznea <claudiu.bez...@microchip.com> > ---
Thanks, queued.
-- Sebastian
> Changes in v2:
> - use devm_of_iomap()
> - change commit description and title to match to the new approach
> - add Suggested-by tag
>
> drivers/power/reset/at91-reset.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/reset/at91-reset.c
> b/drivers/power/reset/at91-reset.c
> index 3ff9d93a5226..026649409135 100644
> --- a/drivers/power/reset/at91-reset.c
> +++ b/drivers/power/reset/at91-reset.c
> @@ -192,7 +192,7 @@ static int __init at91_reset_probe(struct platform_device
> *pdev)
> if (!reset)
> return -ENOMEM;
>
> - reset->rstc_base = of_iomap(pdev->dev.of_node, 0);
> + reset->rstc_base = devm_of_iomap(&pdev->dev, pdev->dev.of_node, 0,
> NULL);
> if (!reset->rstc_base) {
> dev_err(&pdev->dev, "Could not map reset controller address\n");
> return -ENODEV;
> @@ -202,7 +202,7 @@ static int __init at91_reset_probe(struct platform_device
> *pdev)
> /* we need to shutdown the ddr controller, so get ramc base */
> for_each_matching_node_and_match(np, at91_ramc_of_match,
> &match) {
> reset->ramc_lpr = (u32)match->data;
> - reset->ramc_base[idx] = of_iomap(np, 0);
> + reset->ramc_base[idx] = devm_of_iomap(&pdev->dev, np,
> 0, NULL);
> if (!reset->ramc_base[idx]) {
> dev_err(&pdev->dev, "Could not map ram
> controller address\n");
> of_node_put(np);
> --
> 2.25.1
>
signature.asc
Description: PGP signature
