On Thu, Apr 8, 2021 at 5:55 AM Zhao Xuehui <zhaoxueh...@huawei.com> wrote:
>
> The symbol 'HUF_compressWeights_wksp' is not used outside of
> huf_compress.c, so this commit marks it static.
Reviewed-by: Nick Desaulniers <ndesaulni...@google.com>
Quite a few other functions are declared in a header, but I don't see
any existing callers in tree. I wonder if the maintainer could
consider cleaning these up so that we don't retain them in binaries
without dead code elimination enabled, or if there's a need to keep
this code in line with an external upstream codebase?
>
> Signed-off-by: Zhao Xuehui <zhaoxueh...@huawei.com>
> ---
> lib/zstd/huf_compress.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lib/zstd/huf_compress.c b/lib/zstd/huf_compress.c
> index fd32838c185f..1e5e001c3d41 100644
> --- a/lib/zstd/huf_compress.c
> +++ b/lib/zstd/huf_compress.c
> @@ -79,7 +79,8 @@ unsigned HUF_optimalTableLog(unsigned maxTableLog, size_t
> srcSize, unsigned maxS
> * Note : all elements within weightTable are supposed to be <=
> HUF_TABLELOG_MAX.
> */
> #define MAX_FSE_TABLELOG_FOR_HUFF_HEADER 6
> -size_t HUF_compressWeights_wksp(void *dst, size_t dstSize, const void
> *weightTable, size_t wtSize, void *workspace, size_t workspaceSize)
> +static size_t HUF_compressWeights_wksp(void *dst, size_t dstSize, const void
> *weightTable,
> + size_t wtSize, void *workspace, size_t
> workspaceSize)
> {
> BYTE *const ostart = (BYTE *)dst;
> BYTE *op = ostart;
>
--
Thanks,
~Nick Desaulniers
