Re: [Outreachy kernel] [PATCH] staging: rtl8192e: replace comparison to NULL by bool

[Greg KH]

On Sat, Apr 10, 2021 at 02:08:30PM +0200, Julia Lawall wrote:
> 
> 
> On Sat, 10 Apr 2021, Mitali Borkar wrote:
> 
> > Fixed Comparison to NULL can be written as '!...' by replacing it with
> > simpler form i.e boolean expression. This makes code more readable 
> > alternative.
> > Reported by checkpatch.
> >
> > Signed-off-by: Mitali Borkar <mitaliborkar...@gmail.com>
> > ---
> >  drivers/staging/rtl8192e/rtl819x_TSProc.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c 
> > b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> > index 65eac33aaa5b..476875125e87 100644
> > --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c
> > +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c
> > @@ -269,12 +269,12 @@ static void MakeTSEntry(struct ts_common_info 
> > *pTsCommonInfo, u8 *Addr,
> >  {
> >     u8      count;
> >
> > -   if (pTsCommonInfo == NULL)
> > +   if (!pTsCommonInfo)
> >             return;
> >
> >     memcpy(pTsCommonInfo->Addr, Addr, 6);
> >
> > -   if (pTSPEC != NULL)
> > +   if (pTSPEC)
> >             memcpy((u8 *)(&(pTsCommonInfo->TSpec)), (u8 *)pTSPEC,
> >                    sizeof(union tspec_body));
> >
> > @@ -328,7 +328,7 @@ bool GetTs(struct rtllib_device *ieee, struct 
> > ts_common_info **ppTS,
> >     }
> >
> >     *ppTS = SearchAdmitTRStream(ieee, Addr, UP, TxRxSelect);
> > -   if (*ppTS != NULL)
> > +   if (ppTS)
> 
> You lost a * here.

Ugh, good catch.

Mitali, can you send me a fix-up patch for this, or do you want me to
drop your original patch from my tree?

thanks,

greg k-h