Hi Mitali, On Mon, Apr 12, 2021 at 04:38:39AM +0530, Mitali Borkar wrote: > Added #include <linux/bitops.h> and replaced bit shifts by BIT() macro. > This BIT() macro from linux/bitops.h is used to define > IPU3_UAPI_GRID_Y_START_EN > and IPU3_UAPI_AWB_RGBS_THR_B_* bitmask. > Use of macro is better and neater. It maintains consistency. > Reported by checkpatch. > > Signed-off-by: Mitali Borkar <mitaliborkar...@gmail.com> > --- > drivers/staging/media/ipu3/include/intel-ipu3.h | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/media/ipu3/include/intel-ipu3.h > b/drivers/staging/media/ipu3/include/intel-ipu3.h > index edd8edda0647..589d5ccee3a7 100644 > --- a/drivers/staging/media/ipu3/include/intel-ipu3.h > +++ b/drivers/staging/media/ipu3/include/intel-ipu3.h > @@ -5,6 +5,7 @@ > #define __IPU3_UAPI_H > > #include <linux/types.h> > +#include <linux/bitops.h> > > /* from /drivers/staging/media/ipu3/include/videodev2.h */ > > @@ -22,11 +23,11 @@ > #define IPU3_UAPI_MAX_BUBBLE_SIZE 10 > > #define IPU3_UAPI_GRID_START_MASK ((1 << 12) - 1) > -#define IPU3_UAPI_GRID_Y_START_EN (1 << 15) > +#define IPU3_UAPI_GRID_Y_START_EN BIT(15)
This header is used in user space where you don't have the BIT() macro. > > /* controls generation of meta_data (like FF enable/disable) */ > -#define IPU3_UAPI_AWB_RGBS_THR_B_EN (1 << 14) > -#define IPU3_UAPI_AWB_RGBS_THR_B_INCL_SAT (1 << 15) > +#define IPU3_UAPI_AWB_RGBS_THR_B_EN BIT(14) > +#define IPU3_UAPI_AWB_RGBS_THR_B_INCL_SAT BIT(15) > > /** > * struct ipu3_uapi_grid_config - Grid plane config -- Kind regards, Sakari Ailus
