Hi Mitali, Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Mitali-Borkar/Subject-PATCH-staging-media-meson-vdec-declare-u32-as-static-const/20210412-222025 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git f2f560e1bdc055a6a306e6b7823ba589794e6564 config: mips-randconfig-r013-20210412 (attached as .config) compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 9829f5e6b1bca9b61efc629770d28bb9014dec45) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install mips cross compiling tool for clang build # apt-get install binutils-mips-linux-gnu # https://github.com/0day-ci/linux/commit/c9873622761b42d977b48804bb0b4b9a7fbcd6b3 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Mitali-Borkar/Subject-PATCH-staging-media-meson-vdec-declare-u32-as-static-const/20210412-222025 git checkout c9873622761b42d977b48804bb0b4b9a7fbcd6b3 # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=mips If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): >> drivers/staging/media/meson/vdec/codec_h264.c:290:28: error: brackets are >> not allowed here; to declare an array, place the brackets after the >> identifier static const u32[] canvas3 = { ANCO_CANVAS_ADDR, 0 }; ~~ ^ [] >> drivers/staging/media/meson/vdec/codec_h264.c:290:33: error: use of >> undeclared identifier 'ANCO_CANVAS_ADDR' static const u32[] canvas3 = { ANCO_CANVAS_ADDR, 0 }; ^ drivers/staging/media/meson/vdec/codec_h264.c:291:28: error: brackets are not allowed here; to declare an array, place the brackets after the identifier static const u32[] canvas4 = { 24, 0 }; ~~ ^ [] >> drivers/staging/media/meson/vdec/codec_h264.c:293:28: error: passing 'const >> u32 []' to parameter of type 'u32 *' (aka 'unsigned int *') discards >> qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] amvdec_set_canvases(sess, canvas3, canvas4); ^~~~~~~ drivers/staging/media/meson/vdec/vdec_helpers.h:20:8: note: passing argument to parameter 'reg_base' here u32 reg_base[], u32 reg_num[]); ^ drivers/staging/media/meson/vdec/codec_h264.c:293:37: error: passing 'const u32 [2]' to parameter of type 'u32 *' (aka 'unsigned int *') discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers] amvdec_set_canvases(sess, canvas3, canvas4); ^~~~~~~ drivers/staging/media/meson/vdec/vdec_helpers.h:20:24: note: passing argument to parameter 'reg_num' here u32 reg_base[], u32 reg_num[]); ^ 5 errors generated. vim +290 drivers/staging/media/meson/vdec/codec_h264.c 284 285 static void codec_h264_resume(struct amvdec_session *sess) 286 { 287 struct amvdec_core *core = sess->core; 288 struct codec_h264 *h264 = sess->priv; 289 u32 mb_width, mb_height, mb_total; > 290 static const u32[] canvas3 = { ANCO_CANVAS_ADDR, 0 }; 291 static const u32[] canvas4 = { 24, 0 }; 292 > 293 amvdec_set_canvases(sess, canvas3, canvas4); 294 295 dev_dbg(core->dev, "max_refs = %u; actual_dpb_size = %u\n", 296 h264->max_refs, sess->num_dst_bufs); 297 298 /* Align to a multiple of 4 macroblocks */ 299 mb_width = ALIGN(h264->mb_width, 4); 300 mb_height = ALIGN(h264->mb_height, 4); 301 mb_total = mb_width * mb_height; 302 303 h264->ref_size = mb_total * MB_MV_SIZE * h264->max_refs; 304 h264->ref_vaddr = dma_alloc_coherent(core->dev, h264->ref_size, 305 &h264->ref_paddr, GFP_KERNEL); 306 if (!h264->ref_vaddr) { 307 amvdec_abort(sess); 308 return; 309 } 310 311 /* Address to store the references' MVs */ 312 amvdec_write_dos(core, AV_SCRATCH_1, h264->ref_paddr); 313 /* End of ref MV */ 314 amvdec_write_dos(core, AV_SCRATCH_4, h264->ref_paddr + h264->ref_size); 315 316 amvdec_write_dos(core, AV_SCRATCH_0, (h264->max_refs << 24) | 317 (sess->num_dst_bufs << 16) | 318 ((h264->max_refs - 1) << 8)); 319 } 320 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
