On Fri, Apr 09, 2021 at 07:31:53PM -0700, Joe Perches wrote: > On Sat, 2021-04-10 at 07:55 +0530, Mitali Borkar wrote: > > On Fri, Apr 09, 2021 at 07:07:09PM -0700, Joe Perches wrote: > > > On Sat, 2021-04-10 at 07:05 +0530, Mitali Borkar wrote: > > > > Matched the alignment with open parenthesis to meet linux kernel coding > > > > style. > > > > Reported by checkpatch. > > > [] > > > > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c > > > > b/drivers/staging/rtl8192e/rtl819x_HTProc.c > > > [] > > > > @@ -154,7 +154,7 @@ bool IsHTHalfNmodeAPs(struct rtllib_device *ieee) > > > > (net->ralink_cap_exist)) > > > > retValue = true; > > > > else if (!memcmp(net->bssid, UNKNOWN_BORADCOM, 3) || > > > > - !memcmp(net->bssid, > > > > LINKSYSWRT330_LINKSYSWRT300_BROADCOM, 3) || > > > > + !memcmp(net->bssid, > > > > LINKSYSWRT330_LINKSYSWRT300_BROADCOM, 3) || > > > > !memcmp(net->bssid, > > > > LINKSYSWRT350_LINKSYSWRT150_BROADCOM, 3) || > > > > (net->broadcom_cap_exist)) > > > > > > checkpatch is a stupid script. > > > Look further at the code not just at what checkpatch reports. > > > Align all the contination lines, not just the first one. > > > > > Sir, I have aligned them in last patch of this patchset. > > This sort of change should not require an additional patch. > So now should I compile this as a patchset of 5, removing the last patch of alignment? >
