On 4/13/21 11:18 AM, Andrew Morton wrote:
> On Sun, 11 Apr 2021 15:17:56 -0700 Randy Dunlap <rdun...@infradead.org> wrote:
>
>> Fix various kernel-doc warnings in lib/ due to missing or
>> erroneous function names.
>> Add kernel-doc for some function parameters that was missing.
>> Use kernel-doc "Return:" notation in earlycpio.c.
>>
>> Quietens the following warnings:
>>
>> ../lib/earlycpio.c:61: warning: expecting prototype for cpio_data
>> find_cpio_data(). Prototype was for find_cpio_data() instead
>>
>> ../lib/lru_cache.c:640: warning: expecting prototype for lc_dump().
>> Prototype was for lc_seq_dump_details() instead
>> lru_cache.c:90: warning: Function parameter or member 'cache' not described
>> in 'lc_create'
>
> I'm still seeing this.
>
Weird. I can't reproduce it.
>> lru_cache.c:90: warning: Function parameter or member 'cache' not described
>> in 'lc_create'
>
> But it looks OK:
>
Yes.
> /**
> * lc_create - prepares to track objects in an active set
> * @name: descriptive name only used in lc_seq_printf_stats and
> lc_seq_dump_details
> * @cache: cache root pointer
> * @max_pending_changes: maximum changes to accumulate until a transaction is
> required
> * @e_count: number of elements allowed to be active simultaneously
> * @e_size: size of the tracked objects
> * @e_off: offset to the &struct lc_element member in a tracked object
> *
> * Returns a pointer to a newly initialized struct lru_cache on success,
> * or NULL on (allocation) failure.
> */
> struct lru_cache *lc_create(const char *name, struct kmem_cache *cache,
> unsigned max_pending_changes,
> unsigned e_count, size_t e_size, size_t e_off)
> {
>
I'll keep looking...
--
~Randy
