On Wed, Apr 14, 2021 at 11:56 AM Florent Revest <rev...@chromium.org> wrote: > On Wed, Apr 14, 2021 at 1:01 AM Andrii Nakryiko > <andrii.nakry...@gmail.com> wrote: > > On Mon, Apr 12, 2021 at 8:38 AM Florent Revest <rev...@chromium.org> wrote: > > > + err = 0; > > > +out: > > > + put_fmt_tmp_buf(); > > > > so you are putting tmp_buf unconditionally, even when there was no > > error. That seems wrong? Should this be: > > > > if (err) > > put_fmt_tmp_buf() > > > > ? > > Yeah the naming is unfortunate, as discussed in the other patch, I > will rename that to bpf_pintf_cleanup instead. It's not clear from the > name that it only "puts" if the buffer was already gotten.
Ah, sorry I see what you meant! Indeed, my mistake. :|
