Hi Srinivas,

I love your patch! Perhaps something to improve:

[auto build test WARNING on asoc/for-next]
[also build test WARNING on robh/for-next sound/for-next v5.12-rc7 
next-20210414]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/0day-ci/linux/commits/Srinivas-Kandagatla/ASoC-codecs-add-wcd938x-support/20210414-235130
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 
for-next
config: nios2-randconfig-m031-20210414 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

smatch warnings:
sound/soc/codecs/wcd938x.c:1737 wcd938x_add_slave_components() warn: 
inconsistent indenting

vim +1737 sound/soc/codecs/wcd938x.c

  1715  
  1716  static int wcd938x_add_slave_components(struct wcd938x_priv *wcd938x,
  1717                                          struct device *dev,
  1718                                          struct component_match 
**matchptr)
  1719  {
  1720          struct device_node *np;
  1721  
  1722          np = dev->of_node;
  1723  
  1724          wcd938x->rxnode = of_parse_phandle(np, "qcom,rx-device", 0);
  1725          if (!wcd938x->rxnode) {
  1726                  dev_err(dev, "%s: Rx-device node not defined\n", 
__func__);
  1727                  return -ENODEV;
  1728          }
  1729  
  1730          of_node_get(wcd938x->rxnode);
  1731          component_match_add_release(dev, matchptr, wcd938x_release_of,
  1732                                      wcd938x_compare_of, 
wcd938x->rxnode);
  1733  
  1734          wcd938x->txnode = of_parse_phandle(np, "qcom,tx-device", 0);
  1735          if (!wcd938x->txnode) {
  1736                  dev_err(dev, "%s: Tx-device node not defined\n", 
__func__);
> 1737                          return -ENODEV;
  1738          }
  1739          of_node_get(wcd938x->txnode);
  1740          component_match_add_release(dev, matchptr, wcd938x_release_of,
  1741                                      wcd938x_compare_of, 
wcd938x->txnode);
  1742          return 0;
  1743  }
  1744  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

Attachment: .config.gz
Description: application/gzip

Reply via email to