> -----Original Message----- > From: Dominique MARTINET <dominique.marti...@atmark-techno.com> > Sent: 2021年4月19日 12:49 > To: Alice Guo (OSS) <alice....@oss.nxp.com> > Cc: gre...@linuxfoundation.org; raf...@kernel.org; Horia Geanta > <horia.gea...@nxp.com>; Aymen Sghaier <aymen.sgha...@nxp.com>; > herb...@gondor.apana.org.au; da...@davemloft.net; t...@atomide.com; > geert+rene...@glider.be; mturque...@baylibre.com; sb...@kernel.org; > vk...@kernel.org; peter.ujfal...@gmail.com; a.ha...@samsung.com; > narmstr...@baylibre.com; robert.f...@linaro.org; airl...@linux.ie; > dan...@ffwll.ch; khil...@baylibre.com; to...@kernel.org; jyri.sa...@iki.fi; > j...@8bytes.org; w...@kernel.org; mche...@kernel.org; > ulf.hans...@linaro.org; adrian.hun...@intel.com; kis...@ti.com; > k...@kernel.org; linus.wall...@linaro.org; Roy Pledge <roy.ple...@nxp.com>; > Leo Li <leoyang...@nxp.com>; ssant...@kernel.org; matthias....@gmail.com; > edubez...@gmail.com; j-keer...@ti.com; ba...@kernel.org; > li...@prisktech.co.nz; st...@rowland.harvard.edu; w...@linux-watchdog.org; > li...@roeck-us.net; linux-kernel@vger.kernel.org; > linux-cry...@vger.kernel.org; > linux-o...@vger.kernel.org; linux-renesas-...@vger.kernel.org; > linux-...@vger.kernel.org; dmaeng...@vger.kernel.org; > dri-de...@lists.freedesktop.org; linux-amlo...@lists.infradead.org; > linux-arm-ker...@lists.infradead.org; io...@lists.linux-foundation.org; > linux-me...@vger.kernel.org; linux-...@vger.kernel.org; > net...@vger.kernel.org; linux-...@lists.infradead.org; > linux-g...@vger.kernel.org; linuxppc-...@lists.ozlabs.org; > linux-stag...@lists.linux.dev; linux-media...@lists.infradead.org; > linux...@vger.kernel.org; linux-...@vger.kernel.org; > linux-watch...@vger.kernel.org > Subject: Re: [RFC v1 PATCH 1/3] drivers: soc: add support for soc_device_match > returning -EPROBE_DEFER > > First comment overall for the whole serie: > Since it is the solution I had suggested when I reported the problem[1] I > have no > qualm on the approach, comments for individual patches follow. > > [1] http://lore.kernel.org/r/YGGZJjAxA1IO+/v...@atmark-techno.com > > > Alice Guo (OSS) wrote on Mon, Apr 19, 2021 at 12:27:20PM +0800: > > From: Alice Guo <alice....@nxp.com> > > > > In i.MX8M boards, the registration of SoC device is later than caam > > driver which needs it. Caam driver needs soc_device_match to provide > > -EPROBE_DEFER when no SoC device is registered and no > > early_soc_dev_attr. > > This patch should be last in the set: you can't have soc_device_match return > an > error before its callers handle it. > > > Signed-off-by: Alice Guo <alice....@nxp.com> > > As the one who reported the problem I would have been appreciated being at > least added to Ccs... I only happened to notice you posted this by chance.
Sorry. I will Cc you next time. > There is also not a single Fixes tag -- I believe this commit should have > Fixes: > 7d981405d0fd ("soc: imx8m: change to use platform driver") but I'm not sure > how such tags should be handled in case of multiple patches fixing something. I only mentioned "soc: imx8m: change to use platform driver" in cover letter. If it is acceptable to make such a modification, I will send non-RFC and add Fixes tag. Best Regards, Alice > -- > Dominique