Hi "Fabio, Thank you for the patch! Yet something to improve:
[auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Fabio-M-De-Francesco/staging-rtl8192u-Remove-variable-set-but-not-used/20210412-023753 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 1b9e18de8d43bf798622cc365f99b41f180b446f config: x86_64-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/0a66e6b5893f80ddaadaf4811de703afdb15bbc7 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Fabio-M-De-Francesco/staging-rtl8192u-Remove-variable-set-but-not-used/20210412-023753 git checkout 0a66e6b5893f80ddaadaf4811de703afdb15bbc7 # save the attached .config to linux build tree make W=1 W=1 ARCH=x86_64 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/staging/rtl8192u/r8192U_core.c: In function 'rtl8192_hard_data_xmit': >> drivers/staging/rtl8192u/r8192U_core.c:917:2: error: 'ret' undeclared (first >> use in this function); did you mean 'net'? 917 | ret = rtl8192_tx(dev, skb); | ^~~ | net drivers/staging/rtl8192u/r8192U_core.c:917:2: note: each undeclared identifier is reported only once for each function it appears in vim +917 drivers/staging/rtl8192u/r8192U_core.c 8fc8598e61f6f3 Jerry Chuang 2009-11-03 897 8fc8598e61f6f3 Jerry Chuang 2009-11-03 898 /* this function TX data frames when the ieee80211 stack requires this. 8fc8598e61f6f3 Jerry Chuang 2009-11-03 899 * It checks also if we need to stop the ieee tx queue, eventually do it 8fc8598e61f6f3 Jerry Chuang 2009-11-03 900 */ 069b3162590896 Raphaël Beamonte 2015-09-20 901 static void rtl8192_hard_data_xmit(struct sk_buff *skb, struct net_device *dev, 069b3162590896 Raphaël Beamonte 2015-09-20 902 int rate) 8fc8598e61f6f3 Jerry Chuang 2009-11-03 903 { 8fc8598e61f6f3 Jerry Chuang 2009-11-03 904 struct r8192_priv *priv = (struct r8192_priv *)ieee80211_priv(dev); 8fc8598e61f6f3 Jerry Chuang 2009-11-03 905 unsigned long flags; 20f896c4dbb48f simran singhal 2017-02-12 906 struct cb_desc *tcb_desc = (struct cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE); 8fc8598e61f6f3 Jerry Chuang 2009-11-03 907 u8 queue_index = tcb_desc->queue_index; 8fc8598e61f6f3 Jerry Chuang 2009-11-03 908 8fc8598e61f6f3 Jerry Chuang 2009-11-03 909 /* shall not be referred by command packet */ 4a8d1135548baf Xenia Ragiadakou 2013-06-09 910 RTL8192U_ASSERT(queue_index != TXCMD_QUEUE); 8fc8598e61f6f3 Jerry Chuang 2009-11-03 911 8fc8598e61f6f3 Jerry Chuang 2009-11-03 912 spin_lock_irqsave(&priv->tx_lock, flags); 8fc8598e61f6f3 Jerry Chuang 2009-11-03 913 c3f463484bdd0a Ben Hutchings 2016-04-21 914 *(struct net_device **)(skb->cb) = dev; 8fc8598e61f6f3 Jerry Chuang 2009-11-03 915 tcb_desc->bTxEnableFwCalcDur = 1; 8fc8598e61f6f3 Jerry Chuang 2009-11-03 916 skb_push(skb, priv->ieee80211->tx_headroom); 8fc8598e61f6f3 Jerry Chuang 2009-11-03 @917 ret = rtl8192_tx(dev, skb); 8fc8598e61f6f3 Jerry Chuang 2009-11-03 918 8fc8598e61f6f3 Jerry Chuang 2009-11-03 919 spin_unlock_irqrestore(&priv->tx_lock, flags); 8fc8598e61f6f3 Jerry Chuang 2009-11-03 920 } 8fc8598e61f6f3 Jerry Chuang 2009-11-03 921 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
