From: Colin Ian King <colin.k...@canonical.com>

The check for ret < 0 is always false because ret is a (unsigned) size_t
and not a (signed) ssize_t, hence simple_write_to_buffer failures are
never detected. Fix this by making ret a ssize_t

Addresses-Coverity: ("Unsigned compared against 0")
Fixes: 8074a79fad2e ("platform/x86: intel_pmc_core: Add option to set/clear LPM 
mode")
Signed-off-by: Colin Ian King <colin.k...@canonical.com>
---
 drivers/platform/x86/intel_pmc_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel_pmc_core.c 
b/drivers/platform/x86/intel_pmc_core.c
index 3ae00ac85c75..d174aeb492e0 100644
--- a/drivers/platform/x86/intel_pmc_core.c
+++ b/drivers/platform/x86/intel_pmc_core.c
@@ -1360,7 +1360,7 @@ static ssize_t pmc_core_lpm_latch_mode_write(struct file 
*file,
        struct pmc_dev *pmcdev = s->private;
        bool clear = false, c10 = false;
        unsigned char buf[8];
-       size_t ret;
+       ssize_t ret;
        int idx, m, mode;
        u32 reg;
 
-- 
2.30.2

Reply via email to