Existing `blogic_msg' invocations do not appear to overrun its internal 
buffer of a fixed length of 100, which would cause stack corruption, but 
it's easy to miss with possible further updates and a fix is cheap in 
performance terms, so limit the output produced into the buffer by using 
`vscnprintf' rather than `vsprintf'.

Signed-off-by: Maciej W. Rozycki <ma...@orcam.me.uk>
Changes from v1:

- use `vscnprintf' instead of `vsnprintf' for the correct character count.
 drivers/scsi/BusLogic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-macro-ide/drivers/scsi/BusLogic.c
--- linux-macro-ide.orig/drivers/scsi/BusLogic.c
+++ linux-macro-ide/drivers/scsi/BusLogic.c
@@ -3588,7 +3588,7 @@ static void blogic_msg(enum blogic_msgle
        int len = 0;
        va_start(args, adapter);
-       len = vsprintf(buf, fmt, args);
+       len = vscnprintf(buf, sizeof(buf), fmt, args);
        if (msglevel == BLOGIC_ANNOUNCE_LEVEL) {
                static int msglines = 0;

Reply via email to