On Wed, Mar 09, 2022 at 09:08:36PM -0800, Dan Williams wrote: > On Fri, Mar 4, 2022 at 12:38 PM <ira.we...@intel.com> wrote: > > > > From: Ira Weiny <ira.we...@intel.com> > > > > The function run_dax() was missing a prototype when compiling with > > warnings. > > > > Add bus.h to fix this. > > > > Always include the warning and the compiler in the changelog.
Sorry. > I > suspect you hit this with LLVM and not gcc? No this was with gcc. gcc -Wp,-MMD,drivers/dax/.super.o.d -nostdinc -I./arch/x86/include ... -D__KBUILD_MODNAME=kmod_dax -c -o drivers/dax/super.o drivers/dax/super.c ; ./tools/objtool/objtool orc generate --no-fp --retpoline --uaccess drivers/dax/super.o drivers/dax/super.c:276:6: warning: no previous prototype for ‘run_dax’ [-Wmissing-prototypes] 276 | void run_dax(struct dax_device *dax_dev) | ^~~~~~~ > > super.c has no business including bus.h. If the bots are tripping over > this a better fix is to move it into dax-private.h. It was not a bot just me using W=1. I can ignore it or move the prototype to dax-private.h. Ira