* Jeremy Fitzhardinge <[EMAIL PROTECTED]> wrote:

>>  +#if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE)
>> +static void __init runtime_code_page_mkexec(void)
>> +{
>> +    efi_memory_desc_t *md;
>> +    unsigned long end;
>> +    void *p;
>> +
>> +    if (!(__supported_pte_mask & _PAGE_NX))
>> +            return;
>>   
>
> On 32-bit non-PAE, _PAGE_NX == 0, so this if() statement should be 
> sufficient to disable the whole function at compile time without 
> needing the outer #if defined wrapper.

good point. The patch fixes bugs and the consolidation it does is very 
nice so i've applied it already, but we could indeed further consolidate 
it and make it a nice #ifdef-less function. Could one of you send an 
add-on patch for this?

        Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to