On Wed, Nov 16, 2022 at 04:37:37PM -0700, Vishal Verma wrote:
> In a system with a single initiator node, and one or more memory-only
> 'target' nodes, the memory-only node(s) would fail to register their
> initiator node correctly. i.e. in sysfs:
>   # ls /sys/devices/system/node/node0/access0/targets/
>   node0
> Where as the correct behavior should be:
>   # ls /sys/devices/system/node/node0/access0/targets/
>   node0 node1
> This happened because hmat_register_target_initiators() uses list_sort()
> to sort the initiator list, but the sort comparision function
> (initiator_cmp()) is overloaded to also set the node mask's bits.
> In a system with a single initiator, the list is singular, and list_sort
> elides the comparision helper call. Thus the node mask never gets set,
> and the subsequent search for the best initiator comes up empty.
> Add a new helper to consume the sorted initiator list, and generate the
> nodemask, decoupling it from the overloaded initiator_cmp() comparision
> callback. This prevents the singular list corner case naturally, and
> makes the code easier to follow as well.
> Cc: <sta...@vger.kernel.org>
> Cc: Rafael J. Wysocki <raf...@kernel.org>
> Cc: Liu Shixin <liushix...@huawei.com>
> Cc: Dan Williams <dan.j.willi...@intel.com>
> Cc: Kirill A. Shutemov <kirill.shute...@linux.intel.com>
> Reported-by: Chris Piper <chris.d.pi...@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.ve...@intel.com>

Acked-by: Kirill A. Shutemov <kirill.shute...@linux.intel.com>

  Kiryl Shutsemau / Kirill A. Shutemov

Reply via email to