Hi Len,

I saw you added the dmi_get_slot function recently.
If I look in drivers/firmware/dmi_scan.c however I now see:

...

/**
 *      dmi_get_system_info - return DMI data value
 *      @field: data index (see enum dmi_field)
 *
 *      Returns one DMI data value, can be used to perform
 *      complex DMI data checks.
 */
const char *dmi_get_system_info(int field)
{
        return dmi_ident[field];
}
EXPORT_SYMBOL(dmi_get_system_info);

...

/**
 *      dmi_get_slot - return dmi_ident[slot]
 *      @slot:  index into dmi_ident[]
 */
char *dmi_get_slot(int slot)
{
        return(dmi_ident[slot]);
}

Didn't we duplicate code here?

Greetings,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to