Re: [PATCH] parisc/ftrace: add missing CONFIG_DYNAMIC_FTRACE check

[Helge Deller]

On 2/11/24 23:43, Max Kellermann wrote:

Fixes a bug revealed by -Wmissing-prototypes when
CONFIG_FUNCTION_GRAPH_TRACER is enabled but not CONFIG_DYNAMIC_FTRACE:

  arch/parisc/kernel/ftrace.c:82:5: error: no previous prototype for 
'ftrace_enable_ftrace_graph_caller' [-Werror=missing-prototypes]
     82 | int ftrace_enable_ftrace_graph_caller(void)
        |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  arch/parisc/kernel/ftrace.c:88:5: error: no previous prototype for 
'ftrace_disable_ftrace_graph_caller' [-Werror=missing-prototypes]
     88 | int ftrace_disable_ftrace_graph_caller(void)
        |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Max Kellermann <max.kellerm...@ionos.com>

applied to parisc git tree.

Thanks!
Helge

---
  arch/parisc/kernel/ftrace.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/parisc/kernel/ftrace.c b/arch/parisc/kernel/ftrace.c
index d1defb9ede70..621a4b386ae4 100644
--- a/arch/parisc/kernel/ftrace.c
+++ b/arch/parisc/kernel/ftrace.c
@@ -78,7 +78,7 @@ asmlinkage void notrace __hot 
ftrace_function_trampoline(unsigned long parent,
  #endif
  }

-#ifdef CONFIG_FUNCTION_GRAPH_TRACER
+#if defined(CONFIG_DYNAMIC_FTRACE) && defined(CONFIG_FUNCTION_GRAPH_TRACER)
  int ftrace_enable_ftrace_graph_caller(void)
  {
        static_key_enable(&ftrace_graph_enable.key);