Hi! > > > /* > > > * Swap suspend & friends need this for resume because things like the > > > intel-agp > > > * driver might have split up a kernel 4MB mapping. > > > */ > > > -char __nosavedata swsusp_pg_dir[PAGE_SIZE] > > > +char swsusp_pg_dir[PAGE_SIZE] > > > > thanks, applied.
Sorry, this is subtle and I've overlooked it before. (I thought you were only changing ifdef). Now you memcpy() over pg_dir when that pgdir is in use during swsusp resume. Granted, you memcpy() with same data that already are there, but it may still do some funny effects. Hmm, but same argument applies to lower levels of paging in 64-bit and PAE cases, and we still do that memcpy-over-active-pagetables there... :-(. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/