On Tuesday 29 January 2008 01:33:29 am Andi Kleen wrote:
> On Tuesday 29 January 2008 10:05, Yinghai Lu wrote:
> > [PATCH 2/2] x86_64: make early_node_mem return align address
> >
> > boot oops when system get 64g or 128g installed
>
> Probably it should just use reserve_early(). Does this patch work?
>
> The alignment change is needed at some point too, but only to
> relax the alignment to not force all early allocations to be page
> padded.
No, my patch doesn't force all early allocations to be page padded.
for find_e820_mem, i just change PAGE_ALIGN to be aligned align parameter....
only make early_node_mem have aligned data. because it seems it like to...and
assume that.
I think your patch will get early panic about overlap between bss and bootmem...
like the 256g machine, bss is overlapped with early page table...
so could change
- node_data[nodeid] = early_node_mem(nodeid, start, end, pgdat_size);
+ node_data[nodeid] = early_node_mem(nodeid, start, end, pgdat_size,
+ ZONE_ALIGN);
===>
- node_data[nodeid] = early_node_mem(nodeid, start, end, pgdat_size);
+ node_data[nodeid] = early_node_mem(nodeid, start, end, pgdat_size,
+ PAGE_SIZE);
or
- if (mem != -1L)
+ if (mem != -1L) {
+ mem = round_up(mem, PAGE_SIZE);
return __va(mem);
+ }
YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
