On Wed, Apr 02, 2025 at 09:43:55AM +0800, Peng Fan wrote: > On Tue, Apr 01, 2025 at 10:05:03AM -0600, Mathieu Poirier wrote: > >On Tue, Apr 01, 2025 at 09:41:24AM +0800, Peng Fan wrote: ... > > > >The core is already checking if @loaded_table is valid in rproc_start(), why > >can't that be used instead of adding yet another check? > > Ah. I was thinking clear table_sz in rpoc_shutdown is an easy approach and > could benifit others in case other platforms meet similar issue in future. >
I like the general idea of keeping things clean and avoid leaving stale data behind. But clearing table_sz during stop in order to hide the fact that the future table_ptr will contain valid data that shouldn't be used, that's just a bug waiting to show up again in the future. Regards, Bjorn
