On Sat, 3 May 2025 at 05:52, Miguel Ojeda <oj...@kernel.org> wrote: > > It is convenient to have certain things in the `kernel` prelude, and > means kernel developers will find it even easier to start writing tests. > > And, anyway, nobody should need to use this identifier for anything else. > > Thus add it to the prelude. > > Signed-off-by: Miguel Ojeda <oj...@kernel.org> > ---
Definitely a fan of this here, thanks! Reviewed-by: David Gow <david...@google.com> Cheers, -- David > rust/kernel/kunit.rs | 3 +-- > rust/kernel/prelude.rs | 2 +- > rust/macros/lib.rs | 2 +- > 3 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/rust/kernel/kunit.rs b/rust/kernel/kunit.rs > index f43e3ed460c2..053a7da147d5 100644 > --- a/rust/kernel/kunit.rs > +++ b/rust/kernel/kunit.rs > @@ -6,6 +6,7 @@ > //! > //! Reference: <https://docs.kernel.org/dev-tools/kunit/index.html> > > +use crate::prelude::*; > use core::{ffi::c_void, fmt}; > > /// Prints a KUnit error-level message. > @@ -40,8 +41,6 @@ pub fn info(args: fmt::Arguments<'_>) { > } > } > > -use macros::kunit_tests; > - > /// Asserts that a boolean expression is `true` at runtime. > /// > /// Public but hidden since it should only be used from generated tests. > diff --git a/rust/kernel/prelude.rs b/rust/kernel/prelude.rs > index baa774a351ce..e5d61a83952f 100644 > --- a/rust/kernel/prelude.rs > +++ b/rust/kernel/prelude.rs > @@ -17,7 +17,7 @@ > pub use crate::alloc::{flags::*, Box, KBox, KVBox, KVVec, KVec, VBox, VVec, > Vec}; > > #[doc(no_inline)] > -pub use macros::{export, module, vtable}; > +pub use macros::{export, kunit_tests, module, vtable}; > > pub use pin_init::{init, pin_data, pin_init, pinned_drop, InPlaceWrite, > Init, PinInit, Zeroable}; > > diff --git a/rust/macros/lib.rs b/rust/macros/lib.rs > index 8bd7906276be..8b8d46e759d4 100644 > --- a/rust/macros/lib.rs > +++ b/rust/macros/lib.rs > @@ -406,7 +406,7 @@ pub fn paste(input: TokenStream) -> TokenStream { > /// # Examples > /// > /// ```ignore > -/// # use macros::kunit_tests; > +/// # use kernel::prelude::*; > /// #[kunit_tests(kunit_test_suit_name)] > /// mod tests { > /// #[test] > -- > 2.49.0 >
smime.p7s
Description: S/MIME Cryptographic Signature
