On Tue, 10 Jun 2025 06:31:28 +0100,
Anshuman Khandual <[email protected]> wrote:
>
> Change MDSCR_EL1 register holding local variables as uint64_t that reflects
> its true register width as well.
>
> Cc: Marc Zyngier <[email protected]>
> Cc: Oliver Upton <[email protected]>
> Cc: Joey Gouly <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Reviewed-by: Ada Couprie Diaz <[email protected]>
> Signed-off-by: Anshuman Khandual <[email protected]>
> ---
> tools/testing/selftests/kvm/arm64/debug-exceptions.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/kvm/arm64/debug-exceptions.c
> b/tools/testing/selftests/kvm/arm64/debug-exceptions.c
> index c7fb55c9135b..e34963956fbc 100644
> --- a/tools/testing/selftests/kvm/arm64/debug-exceptions.c
> +++ b/tools/testing/selftests/kvm/arm64/debug-exceptions.c
> @@ -140,7 +140,7 @@ static void enable_os_lock(void)
>
> static void enable_monitor_debug_exceptions(void)
> {
> - uint32_t mdscr;
> + uint64_t mdscr;
>
> asm volatile("msr daifclr, #8");
>
> @@ -223,7 +223,7 @@ void install_hw_bp_ctx(uint8_t addr_bp, uint8_t ctx_bp,
> uint64_t addr,
>
> static void install_ss(void)
> {
> - uint32_t mdscr;
> + uint64_t mdscr;
>
> asm volatile("msr daifclr, #8");
>
Why change this in the place that matters *the least*?
arch/arm64/kernel/debug-monitors.c is full of 32bit manipulation of
this register, and that's only one example of it. So if you are going
to change this, please do it fully, not as a random change in a random
file.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
