On Mon, 23 Jun 2025 00:32:05 +0530 Shivank Garg <shiva...@amd.com> wrote:
> > -EXPORT_SYMBOL(__filemap_get_folio);
> > +EXPORT_SYMBOL(__filemap_get_folio_mpol);
> >
> > static inline struct folio *find_get_entry(struct xa_state *xas, pgoff_t
> > max,
> > xa_mark_t mark)
> > _
> >
>
> Hi Andrew,
>
> Thank you for addressing this.
>
> If you don’t mind me asking,
> I was curious why we used EXPORT_SYMBOL instead of EXPORT_SYMBOL_GPL here.
> I had previously received feedback recommending the use of EXPORT_SYMBOL_GPL
> to better align with the kernel’s licensing philosophy, which made sense to
> me.
Making this _GPL would effectively switch __filemap_get_folio() from
non-GPL to GPL. Leaving it at non-GPL is less disruptive and Matthew's
patch did not have the intention of changing licensing.
Also,
hp2:/usr/src/25> grep "EXPORT_SYMBOL(" mm/filemap.c|wc -l
48
hp2:/usr/src/25> grep "EXPORT_SYMBOL_GPL(" mm/filemap.c|wc -l
9
