hrtimer_nanosleep:

        /* Absolute timers do not update the rmtp value and restart: */
        return -ERESTARTNOHAND;

This is not right, -ERESTARTNOHAND means we will do restart if there is no
in fact pending signal, and worse, this restart will use the same unchanged
"__user *rmtp" parameter.

Use -EINTR instead.

Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]>

--- MM/kernel/hrtimer.c~HRT_RMTP~       2008-01-27 17:07:39.000000000 +0300
+++ MM/kernel/hrtimer.c~HRT_RMTP        2008-02-01 13:43:52.000000000 +0300
@@ -1359,7 +1359,7 @@ long hrtimer_nanosleep(struct timespec *
 
        /* Absolute timers do not update the rmtp value and restart: */
        if (mode == HRTIMER_MODE_ABS)
-               return -ERESTARTNOHAND;
+               return -EINTR;
 
        if (rmtp) {
                rem = ktime_sub(t.timer.expires, t.timer.base->get_time());

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Reply via email to