On 01/07/2025 12:12, Luca Weiss wrote: > Hi Krzysztof, > > On Tue Jul 1, 2025 at 10:12 AM CEST, Krzysztof Kozlowski wrote: >> On Fri, Jun 27, 2025 at 08:55:42AM +0200, Luca Weiss wrote: >>> @@ -91,6 +93,7 @@ allOf: >>> properties: >>> compatible: >>> enum: >>> + - qcom,sm7635-mpss-pas >>> - qcom,sm8350-mpss-pas >>> - qcom,sm8450-mpss-pas >>> then: >>> @@ -142,6 +145,22 @@ allOf: >>> - const: cx >>> - const: mxc >>> >>> + - if: >>> + properties: >>> + compatible: >>> + enum: >>> + - qcom,sm7635-wpss-pas >> >> Everything fits better sm6350 and no need for new if:then: entry, at >> least it looks like. > > True, that seems to work fine as well. I can add it to the > qcom,sm6350-pas.yaml bindings instead of sm8350 in the next version. > > To be honest, I don't quite understand what the concept behind the > different PAS bindings are, when an SoC should get a new .yaml file, and > when to add to an existing one.
It is purely arbitrary way of organizing things, to reduce amount of ifs:then: and make things easier to read. Adding ifs: does not make it simple. Adding same SoC to multiple bindings does not make it simple. Best regards, Krzysztof
