On Thu Jul 3, 2025 at 9:41 AM CEST, Krzysztof Kozlowski wrote: > On Wed, Jul 02, 2025 at 05:56:16PM +0200, Luca Weiss wrote: >> Document the Top Level Mode Multiplexer on the Milos Platform. > > What is Milos platform? Does it have some sort of model number how we > usually expect? Wasn't this SM7325 or similar? > > The problem with such new naming that it awfully sounds like family > names, so just expand the name and explain it.
Please go argue with Bjorn/Konrad about this, wasn't my idea. https://lore.kernel.org/linux-arm-msm/agmi1zv6d+k+v...@hu-bjorande-lv.qualcomm.com/ https://lore.kernel.org/linux-arm-msm/b98d305b-247f-415b-8675-50d073452...@oss.qualcomm.com/ Regards Luca > >> >> Signed-off-by: Luca Weiss <luca.we...@fairphone.com> >> --- >> .../bindings/pinctrl/qcom,milos-tlmm.yaml | 133 >> +++++++++++++++++++++ >> 1 file changed, 133 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,milos-tlmm.yaml >> b/Documentation/devicetree/bindings/pinctrl/qcom,milos-tlmm.yaml >> new file mode 100644 >> index >> 0000000000000000000000000000000000000000..0091204df20a0eca7d0d0e766afcb8d08042b015 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,milos-tlmm.yaml >> @@ -0,0 +1,133 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/pinctrl/qcom,milos-tlmm.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Technologies, Inc. Milos TLMM block >> + >> +maintainers: >> + - Luca Weiss <luca.we...@fairphone.com> >> + >> +description: >> + Top Level Mode Multiplexer pin controller in Qualcomm Milos SoC. >> + >> +allOf: >> + - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml# >> + >> +properties: >> + compatible: >> + const: qcom,milos-tlmm > > Before you start adding such 'milos' all over the code, you need to > update the rule for compatible naming. I don't know how thus I would not > recomment the switch from obvious model number to non-obvious cryptic > alias. > > Best regards, > Krzysztof
