On Fri Jul 4, 2025 at 9:37 AM CEST, Andreas Hindborg wrote: > Andreas Hindborg <[email protected]> writes: > >> "Danilo Krummrich" <[email protected]> writes: >> >>> On 7/2/25 3:18 PM, Andreas Hindborg wrote: >>>> + /// Get a shared reference to the parameter value. >>>> + // Note: When sysfs access to parameters are enabled, we have to pass >>>> in a >>>> + // held lock guard here. >>>> + pub fn get(&self) -> &T { >>>> + self.value.as_ref().unwrap_or(&self.default) >>>> + } >>> >>> I think you forgot to rename this. >> >> Yes, thanks for being persistent on this :) > > Actually, there is a discussion on whether to keep the API similar to > `std::sync::OnceLock` [1] but also whether to rename this to something > other than `OnceLock` [2]. Depending on how that resolves, it might make > sense to stay with `get` or rename to something else.
But this is for the `ModuleParamAccess`, right? There I think it makes sense to choose `access` or `value`. --- Cheers, Benno > Best regards, > Andreas Hindborg > > > [1] > https://lore.kernel.org/all/[email protected] > [2] > https://lore.kernel.org/all/CAH5fLggY2Ei14nVJzLBEoR1Rut1GKU4SZX=+14turh1asuq...@mail.gmail.com
