On 14.07.25 15:39, Mark Brown wrote:
On Mon, Jul 14, 2025 at 09:00:09PM +0800, wang lian wrote:
Move the generic `FORCE_READ` macro from `guard-regions.c` to the shared
`vm_util.h` header to promote code reuse.
In `guard-regions.c`, replace `ksft_exit_skip()` with the `SKIP()` macro
to ensure only the current test is skipped on permission failure, instead
of terminating the entire test binary.
These two changes look fine but they're not really related so should be
separate patches. Looking briefly at guard-regions.c I see a bunch more
use of ksft_exit_ functions that ought to be fixed as well, but your fix
is good.
The FORCE_READ() could be factored out separately, and as part of the
same patch, replace the "asm volatile("" : "+r" (XXX));" usage in
* cow.c
* hugetlb-madvise.c
* migration.c
* pagemap_ioctl.c
* split_huge_page_test.c
--
Cheers,
David / dhildenb
