On 7/19/25 04:22, Jarkko Sakkinen wrote: > On Tue, Jul 15, 2025 at 03:40:22PM +0300, Elena Reshetova wrote: >> -static int __maybe_unused sgx_update_svn(void) >> +static int sgx_update_svn(void) > I'd combine 4/5 and 5/5 because of this. Makes them so much easier to > backtrack changes later on if this type of stuff is avoided when > possible.
I'm not really sure what "backtracking changes" is, but I disagree on this one. Breaking up patches is about reducing the mental load to review things. Generally, the smaller the patch, the smaller the mental load. That breaks down when, for instance, a helper has a complicated argument handling or return codes. But, in this case, we have a function that takes no arguments and returns standard -ERROR codes. It's fine to break it out like this. No reason to do more patch gymnastics at this point to squash it.
