On Thu, Jul 24, 2025 at 04:17:07PM -0600, Shuah Khan wrote: > On 7/24/25 12:26, Shuah Khan wrote: > > On 7/23/25 17:13, Paul E. McKenney wrote: > > > The pidfd selftests run in userspace and include both userspace and kernel > > > header files. On some distros (for example, CentOS), this results in > > > duplicate-symbol warnings in allmodconfig builds, while on other distros > > > (for example, Ubuntu) it does not. > > > > > > Therefore, use #undef to get rid of the userspace definitions in favor > > > of the kernel definitions. > > > > > > Other ways of handling this include splitting up the selftest code so > > > that the userspace definitions go into one translation unit and the > > > kernel definitions into another (which might or might not be feasible) > > > or to adjust compiler command-line options to suppress the warnings > > > (which might or might not be desirable). > > > > > > [ paulmck: Apply Shuah Khan feedback. ] > > > > Looks good to me. > > I picked this up for Linux 6.17-rc1.
Thank you, Shuah! Thanx, Paul