Use the device lifecycle managed add function. This helps prevent mistakes
like deleting out of order in cleanup functions and forgetting to delete
on error paths.

Signed-off-by: Andrew Davis <a...@ti.com>
---
 drivers/remoteproc/wkup_m3_rproc.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/remoteproc/wkup_m3_rproc.c 
b/drivers/remoteproc/wkup_m3_rproc.c
index 30e9ecd75657f..2d5bfbefcacc5 100644
--- a/drivers/remoteproc/wkup_m3_rproc.c
+++ b/drivers/remoteproc/wkup_m3_rproc.c
@@ -210,20 +210,13 @@ static int wkup_m3_rproc_probe(struct platform_device 
*pdev)
 
        dev_set_drvdata(dev, rproc);
 
-       ret = rproc_add(rproc);
+       ret = devm_rproc_add(dev, rproc);
        if (ret)
                return dev_err_probe(dev, ret, "rproc_add failed\n");
 
        return 0;
 }
 
-static void wkup_m3_rproc_remove(struct platform_device *pdev)
-{
-       struct rproc *rproc = platform_get_drvdata(pdev);
-
-       rproc_del(rproc);
-}
-
 #ifdef CONFIG_PM
 static int wkup_m3_rpm_suspend(struct device *dev)
 {
@@ -242,7 +235,6 @@ static const struct dev_pm_ops wkup_m3_rproc_pm_ops = {
 
 static struct platform_driver wkup_m3_rproc_driver = {
        .probe = wkup_m3_rproc_probe,
-       .remove = wkup_m3_rproc_remove,
        .driver = {
                .name = "wkup_m3_rproc",
                .of_match_table = wkup_m3_rproc_of_match,
-- 
2.39.2


Reply via email to