On Thu, 21 Aug 2025 17:31:21 +0500 Muhammad Usama Anjum <usama.an...@collabora.com> wrote:
> > My > > feeling is that unused parameters are expected to be allowed in the > > kernel and it isn't helpful to go against that expectation in just a > > small subset of kselftests. > I thought kernel must be giving error for unused parameters as well (from > my memory). But just checked and it doesn't seem like it. I'm okay with > dropping -Wunused-parameters. > > We need to drop patch 6/7 and in Patch 4 should have only: > > -CFLAGS += -Wunused -Wunused-parameter -Wunused-function -Wunused-label > -Wunused-variable -Wunused-value > +CFLAGS += -Wunused > > @Andrew, Should I resend the entire series or would you can make the change? I think a new series would be clearer, please. It's unclear (to me) whether Kevin's various comments have all been addressed.
