On 23/08/2025 17:46, Krzysztof Kozlowski wrote: > On 23/08/2025 17:41, Krzysztof Kozlowski wrote: >> On 22/08/2025 17:13, Mukesh Ojha wrote: >>> On Fri, Aug 22, 2025 at 10:45:50AM +0200, Krzysztof Kozlowski wrote: >>>> On 19/08/2025 18:54, Mukesh Ojha wrote: >>>>> +int iris_fw_init(struct iris_core *core) >>>>> +{ >>>>> + struct platform_device_info info; >>>>> + struct iommu_domain *iommu_dom; >>>>> + struct platform_device *pdev; >>>>> + struct device_node *np; >>>>> + int ret; >>>>> + >>>>> + np = of_get_child_by_name(core->dev->of_node, "video-firmware"); >>>> >>>> Undocumented ABI. >>>> >>>> If you tested your DTS, you would notice warnings. >>> >>> qcom,venus-common.yaml is documenting video-firmware and getting included in >>> Documentation/devicetree/bindings/media/qcom,sm8550-iris.yaml >> >> Uh, why? Why does qcom keep this legacy pattern also for iris? > > I will remove it btw, because it is a fake device node (not for a real > device).
So also to clarify: drop it here, because it will be undocumented. Anyway such fake node was NAKed in other context. Best regards, Krzysztof