Andy Shevchenko, 2025-08-29T18:47:19+03:00:
> On Fri, Aug 29, 2025 at 1:18 AM Duje Mihanović <d...@dujemihanovic.xyz> wrote:
>>
>> Add a cell for the PMIC's onboard General Purpose ADC.
>
> ...
>
>>  static const struct mfd_cell pm886_devs[] = {
>
>>         MFD_CELL_RES("88pm886-onkey", pm886_onkey_resources),
>>         MFD_CELL_NAME("88pm886-regulator"),
>>         MFD_CELL_NAME("88pm886-rtc"),
>> +       MFD_CELL_NAME("88pm886-gpadc"),
>
> List seems ordered, please prevent it.

Ah, I never explicitly realized to keep it ordered, seems like I was
just lucky to implement the components in the right order :-)

Anyway, yes, please keep it ordered. When you fix that, you may add

Acked-by: Karel Balej <bal...@matfyz.cz> # for the PMIC

Thanks,
K. B.

Reply via email to