On 15/08/25 04:12PM, Dave Jiang wrote:


On 7/30/25 5:11 AM, Neeraj Kumar wrote:
<snip>

diff --git a/drivers/nvdimm/nd.h b/drivers/nvdimm/nd.h
index 651847f1bbf9..15d94e3937f0 100644
--- a/drivers/nvdimm/nd.h
+++ b/drivers/nvdimm/nd.h
@@ -322,6 +322,26 @@ static inline void nsl_set_region_uuid(struct 
nvdimm_drvdata *ndd,
                export_uuid(ns_label->cxl.region_uuid, uuid);
 }

+static inline bool rgl_uuid_equal(struct cxl_region_label *rg_label,
+                                 const uuid_t *uuid)
+{
+       uuid_t tmp;
+
+       import_uuid(&tmp, rg_label->uuid);
+       return uuid_equal(&tmp, uuid);

Why the extra copy via import_uuid() rather than directly compare rg_labe->uuid 
vs the uuid param?

DJ

Thanks Dave for your suggestion. I have used because of import_uuid()
and uuid_equal() signature difference. Sure I will use uuid_equal()
directly using typecasting and will modify it in next patch-set.

Regards,
Neeraj


Reply via email to