On Thu, Sep 4, 2025 at 7:17 AM Maciej Fijalkowski <maciej.fijalkow...@intel.com> wrote: > > On Thu, Sep 04, 2025 at 12:10:15PM +0200, Bastien Curutchet (eBPF Foundation) > wrote: > > Hi all, > > > > This is a second version of a series I sent some time ago, it continues > > the work of migrating the script tests into prog_tests. > > > > The test_xsk.sh script covers many AF_XDP use cases. The tests it runs > > are defined in xksxceiver.c. Since this script is used to test real > > hardware, the goal here is to leave it as it is, and only integrate the > > tests that run on veth peers into the test_progs framework. > > > > Some tests are flaky so they can't be integrated in the CI as they are. > > I think that fixing their flakyness would require a significant amount of > > work. So, as first step, I've excluded them from the list of tests > > migrated to the CI (see PATCH 13). If these tests get fixed at some > > point, integrating them into the CI will be straightforward. > > > > PATCH 1 extracts test_xsk[.c/.h] from xskxceiver[.c/.h] to make the > > tests available to test_progs. > > PATCH 2 to 5 fix small issues in the current test > > PATCH 7 to 12 handle all errors to release resources instead of calling > > exit() when any error occurs. > > PATCH 13 isolates some flaky tests > > PATCH 14 integrate the non-flaky tests to the test_progs framework > > > > Maciej, I've fixed the bug you found in the initial series. I've > > looked for any hardware able to run test_xsk.sh in my office, but I > > couldn't find one ... So here again, only the veth part has been tested, > > sorry about that. > > Hi Bastien, > > just a heads up, I won't be able to review this until 15 sept. If anyone > else would pick this up earlier then good, otherwise please stay patient > :)
Maciej, Sep 15 is today... just bumping it in your todo list :) Pls take a look.